Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REST endpoint /clear_packets to trigger packet clearing #3401

Merged
merged 7 commits into from
Sep 13, 2023

Conversation

romac
Copy link
Member

@romac romac commented Jun 6, 2023

Closes: #3398

Description

Add a /clear_packets?chain=CHAIN_ID endpoint to the built-in REST server to trigger packet clear for the chain specified in the chain query param or for all chains if the query param is omitted.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac marked this pull request as ready for review August 25, 2023 14:47
@romac romac force-pushed the romac/3398-clear-packet-endpoint branch from 43c1842 to 71b3eb1 Compare August 25, 2023 14:49
@romac romac merged commit b502df2 into master Sep 13, 2023
38 of 39 checks passed
@romac romac deleted the romac/3398-clear-packet-endpoint branch September 13, 2023 08:48
@puneet2019
Copy link
Contributor

hey @romac , is there any way, and can it be added?
/clear-packets/{channel-id}/{sequence_number} - to clear a single specific packet.
Rest and CLI both.

@romac
Copy link
Member Author

romac commented Oct 20, 2023

@puneet2019 Tracked here: #3672

Unfortunately I can't promise a timeline for when we can get to it as we have very limit d bandwidth until next year.

@taitruong
Copy link

Hi, I've been testing this on 1.7.0 - but seems not to be released yet? Tried these:

http://localhost:3000/clear_packets?chain_id=pisco-1
http://localhost:3000/clear_packets?chain=pisco-1

None works - endpoint seems not to be avaiable. http://localhost:3000/state works though

@taitruong
Copy link

just tested with 1.7.1
http://localhost:3001/clear_packets returns 404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger packet processing manually through an endpoint
4 participants