Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homogenize ConnectionReader functions #349

Merged
merged 3 commits into from
Nov 2, 2020
Merged

Homogenize ConnectionReader functions #349

merged 3 commits into from
Nov 2, 2020

Conversation

adizere
Copy link
Member

@adizere adizere commented Oct 30, 2020

Closes: cosmos/ibc-rs#102

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

ancazamfir
ancazamfir approved these changes Nov 2, 2020
View reviewed changes
Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@ancazamfir ancazamfir merged commit 955a3b1 into informalsystems:master Nov 2, 2020
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@adizere @CharlyCst
Homogenize ConnectionReader functions (informalsystems#349)
e57f948 
* ConnectionReader.connection_end returns owned val

* Removed redundant clones, updated changelog; ready to fix #347.

Co-authored-by: CharlyCst <castes.ch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancazamfir ancazamfir ancazamfir approved these changes

@romac romac romac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adizere @romac @ancazamfir @CharlyCst