Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ICQ tests for interchain-security tests #3494

Merged
merged 10 commits into from
Jul 25, 2023
Merged

Add ICQ tests for interchain-security tests #3494

merged 10 commits into from
Jul 25, 2023

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Jul 24, 2023

Closes: #XXX

Description

This PR adds a test for ICQs with Provider / Consumer chains

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 requested a review from romac July 24, 2023 08:19
@ljoss17 ljoss17 marked this pull request as ready for review July 24, 2023 08:21
romac
romac approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ljoss17 ljoss17 merged commit b89ac4b into master Jul 25, 2023
@ljoss17 ljoss17 deleted the luca_joss/icq-tests-for-interchain-security-chains branch July 25, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljoss17 @romac