Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interchain-security tests flakiness #3518

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Aug 2, 2023

Closes: #3519

Description

Bootstrapping provider-consumer chains requires a governance proposal to pass before starting the consumer chain. This PR fixes the flakiness caused by increasing the wait time as it was too close to the voting period. The wait time was previously set to 10s and is now set to 15s.

This PR also adds 2 helper functions to correctly overwrite the config for provier-consumer chains:

  • update_genesis_for_consumer_chain sets the voting period to 10s as the bootstrap will wait 15s
  • update_relayer_config_for_consumer_chain will set ccv_consumer_chain = true for any chains with id ibcconsumer and set the trusting_period = 99 as it needs to be lower than the unbonding_period set in the governance proposal which is 100s.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 requested review from soareschen and romac August 2, 2023 11:37
@ljoss17 ljoss17 added I: CI/CD Internal: related to CI/CD pipeline O: interchain-security Objective: related to Interchain Security labels Aug 2, 2023
@romac
Copy link
Member

romac commented Aug 2, 2023

Excellent!

@romac romac merged commit dfae384 into master Aug 2, 2023
@romac romac deleted the luca_joss/stabilize-provider-consumer-tests branch August 2, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: CI/CD Internal: related to CI/CD pipeline O: interchain-security Objective: related to Interchain Security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky interchain-security tests
2 participants