Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KeyFile associated type to SigningKeyPair trait #3568

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Add KeyFile associated type to SigningKeyPair trait #3568

merged 1 commit into from
Aug 26, 2023

Conversation

DaviRain-Su
Copy link
Contributor

This commit refactors the key pair implementations, adding a KeyFile type for each one.

Closes: #XXX

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

This commit refactors the key pair implementations, adding a `KeyFile` type for each one.
@romac romac changed the title Enable SigningKeyPair trait from_key_file method KeyFile to Associate type Add KeyFile associated type to SigningKeyPair trait Aug 26, 2023
@romac romac merged commit 430c180 into informalsystems:master Aug 26, 2023
@DaviRain-Su DaviRain-Su deleted the enable-keyfile-to-associate-type branch August 26, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants