Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document discard_abci_responses and pull-mode relaying interaction in the Hermes guide #3635

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Document discard_abci_responses and pull-mode relaying interaction in the Hermes guide #3635

merged 4 commits into from
Sep 27, 2023

Conversation

seanchen1991
Copy link
Contributor

@seanchen1991 seanchen1991 commented Sep 21, 2023 •
edited
Loading

Closes: #3634
Closes: #3614
Closes: #3616

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac
Copy link
Member

romac commented Sep 27, 2023

Thanks @seanchen1991!

@romac romac merged commit d23fe64 into master Sep 27, 2023
3 checks passed
@romac romac deleted the sean/hermes-version-commit-hash branch September 27, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@seanchen1991 @romac