Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to read a key/mnemonic from stdin in keys add command #3645

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

romac
Copy link
Member

@romac romac commented Oct 2, 2023

Closes: #3625

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac requested review from ljoss17 and removed request for ljoss17 October 2, 2023 12:03
@romac romac force-pushed the romac/doc-stdin-keys-add branch from f9bc4d0 to 194ac25 Compare October 2, 2023 12:22
@romac romac merged commit ddd6c07 into master Oct 2, 2023
35 of 38 checks passed
@romac romac deleted the romac/doc-stdin-keys-add branch October 2, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hermes could accept mnemonics on the command line or via stdin
1 participant