Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new clippy warnings on Rust 1.74 #3653

Merged
merged 1 commit into from
Oct 5, 2023

Fix new clippy warnings on Rust 1.74

95fda39
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix new clippy warnings on Rust 1.74 #3653

Fix new clippy warnings on Rust 1.74
95fda39
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy-no-default-features failed Oct 5, 2023 in 0s

clippy-no-default-features

2 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 2
Warning 0
Note 0
Help 0

Versions

  • rustc 1.73.0 (cc66ad468 2023-10-03)
  • cargo 1.73.0 (9c4383fb5 2023-08-26)
  • clippy 0.1.73 (cc66ad4 2023-10-03)

Annotations

Check failure on line 438 in crates/relayer-cli/src/commands/tx/client.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unnecessary parentheses around block return value

error: unnecessary parentheses around block return value
   --> crates/relayer-cli/src/commands/tx/client.rs:438:17
    |
438 |                 (self.reference_chain_id != chain.id
    |                 ^
439 |                     && (self.host_chain_id.is_none()
440 |                         || self.host_chain_id == Some(chain.id.clone())))
    |                                                                         ^
    |
    = note: `-D unused-parens` implied by `-D warnings`
help: remove these parentheses
    |
438 ~                 self.reference_chain_id != chain.id
439 |                     && (self.host_chain_id.is_none()
440 ~                         || self.host_chain_id == Some(chain.id.clone()))
    |

Check failure on line 438 in crates/relayer-cli/src/commands/tx/client.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unnecessary parentheses around block return value

error: unnecessary parentheses around block return value
   --> crates/relayer-cli/src/commands/tx/client.rs:438:17
    |
438 |                 (self.reference_chain_id != chain.id
    |                 ^
439 |                     && (self.host_chain_id.is_none()
440 |                         || self.host_chain_id == Some(chain.id.clone())))
    |                                                                         ^
    |
    = note: `-D unused-parens` implied by `-D warnings`
help: remove these parentheses
    |
438 ~                 self.reference_chain_id != chain.id
439 |                     && (self.host_chain_id.is_none()
440 ~                         || self.host_chain_id == Some(chain.id.clone()))
    |