Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ICS test bootstrapping #3657

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Oct 11, 2023

Closes: #XXX

Description

This PR updates the latest Gaia used in the CI, from v11 to v12.

It also fixes an issue when bootstrapping a consumer chain by explicitly setting the gas used when submitting the governance proposal.
It also improves the setup by querying the proposal in order to verify if it is in voting period before voting, and if the proposal passed before starting the consumer chain.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 requested a review from romac October 11, 2023 14:50
@romac
Copy link
Member

romac commented Oct 11, 2023

Amazing, thanks so much 🎉

@ljoss17 ljoss17 merged commit 7688db7 into master Oct 12, 2023
37 checks passed
@ljoss17 ljoss17 deleted the luca_joss/fix-ics-tests-bootstrapping branch October 12, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants