Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs improvements #3661

Merged
merged 10 commits into from
Oct 19, 2023
Merged

Docs improvements #3661

merged 10 commits into from
Oct 19, 2023

Conversation

seanchen1991
Copy link
Contributor

Closes: #3655
Closes: #3654

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@seanchen1991 seanchen1991 requested a review from ljoss17 October 16, 2023 20:48
ljoss17
ljoss17 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@seanchen1991 seanchen1991 requested a review from romac October 19, 2023 13:32
@romac romac merged commit 3a41f69 into master Oct 19, 2023
42 checks passed
@romac romac deleted the sean/docs-improvements branch October 19, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljoss17 ljoss17 ljoss17 approved these changes

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve documentation related to counterparty payee ICS29 Improve pull/poll mode documentation
3 participants
@seanchen1991 @romac @ljoss17