Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump compatiblity check for SDK 0.50 and IBC-Go v8 #3749

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Bump compatiblity check for SDK 0.50 and IBC-Go v8 #3749

merged 4 commits into from
Jan 5, 2024

Conversation

romac
Copy link
Member

@romac romac commented Jan 5, 2024 •
edited
Loading

Closes: #3745

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac requested a review from ljoss17 January 5, 2024 08:37
ljoss17
ljoss17 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a small question

crates/relayer/src/chain/cosmos/compatibility.rs Outdated Show resolved Hide resolved
ljoss17
ljoss17 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only missing the update in the guide

guide/src/advanced/features.md Outdated Show resolved Hide resolved
@romac @ljoss17
Update compat range in guide
b0d6036 
Co-authored-by: Luca Joss <43531661+ljoss17@users.noreply.github.com>
Signed-off-by: Romain Ruetschi <github@romac.me>
@romac romac requested a review from ljoss17 January 5, 2024 09:46
@ljoss17
Update guide/src/advanced/features.md
250551d 
Signed-off-by: Luca Joss <43531661+ljoss17@users.noreply.github.com>
ljoss17
ljoss17 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@romac romac merged commit 2ec3ca4 into master Jan 5, 2024
34 checks passed
@romac romac deleted the romac/0.50-compat branch January 5, 2024 12:10
@ancazamfir ancazamfir mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljoss17 ljoss17 ljoss17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update compatibility check to allow IBC-Go v8+ and SDK v0.50+
2 participants
@romac @ljoss17