Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ICA channel close test after packet timeout #3779

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Add ICA channel close test after packet timeout #3779

merged 3 commits into from
Jan 15, 2024

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Jan 15, 2024

Closes: #3778

Description

This PR adds an ICA test to assert that the channel correctly closes after a packet timeout

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 requested a review from romac January 15, 2024 08:47
romac
romac approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@ljoss17 ljoss17 merged commit ba0e7b6 into master Jan 15, 2024
28 checks passed
@ljoss17 ljoss17 deleted the luca_joss/add-ica-timeout-test branch January 15, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Close ordered channel upon packet timeout
2 participants
@ljoss17 @romac