Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multihop support to packet relaying #4086

Merged
merged 25 commits into from
Sep 10, 2024
Merged

Add multihop support to packet relaying #4086

merged 25 commits into from
Sep 10, 2024

Conversation

joaotav
Copy link
Collaborator

@joaotav joaotav commented Jul 11, 2024

Closes: #4084

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac force-pushed the joaotav/4084-multihop-packet-relaying branch from bcb98ec to 19b7512 Compare July 15, 2024 12:27
@romac romac force-pushed the joaotav/4084-multihop-packet-relaying branch from 9be8f0b to b38bee8 Compare July 16, 2024 10:27
@romac romac force-pushed the joaotav/4084-multihop-packet-relaying branch from b38bee8 to 93ea291 Compare July 16, 2024 10:33
@joaotav
Change ChannelConnectionClient into an enum
bd03d5f 
* Change `ChannelConnectionClient` with an enum with `SingleHop` and
  `Multihop` variants

* Add structs `ChannelConnectionClientSingleHop` and
  `ChannelConnectionClientMultihop` and new corresponding errors
@joaotav
Add pattern matching when using ChannelConnectionClient to handle s…
1839085 
…ingle-hop and multihop cases
@joaotav
Add (MULTIHOP) tag to FIXMEs to indicate multihop specific issues
d5cebac
@joaotav
Merge remote-tracking branch 'origin/master' into joaotav/4084-multih…
3bf7b0c 
…op-packet-relaying
@joaotav
Merge remote-tracking branch 'origin/joaotav/multihop-poc' into joaot…
8606c04 
…av/4084-multihop-packet-relaying
@joaotav
perf: change ok_or to ok_or_else for minor performance improvements
5702c48
@joaotav
Add method channel() to enum ChannelConnectionClient
deee3aa 
* Rename variables for consistency
@joaotav
Add multihop channel support to Link::new_from_opts()
b0f942f 
* Add method `is_multihop()` to struct `RelayPath`

* Add frozen client checks to `channel_connection_client()`
@joaotav
Add method has_frozen_client() to enum ChannelConnectionClient
c002800 
* Remove frozen client check from function `channel_connection_client()`
@joaotav
Modify connection hops handling in Link::new_from_opts() for
a67d127 
consistency
@ljoss17 @joaotav
Add transfer test for multihop channel (#4090)
8c37bd5 
* Add test for a simple transfer on a newly opened multihop channel

* Move multihop IBC transfer inside supervisor block

---------

Co-authored-by: João <joaootaviors@gmail.com>
@romac romac marked this pull request as ready for review September 10, 2024 15:05
@romac romac marked this pull request as draft September 10, 2024 15:09
@romac romac merged commit 8c37bd5 into joaotav/multihop-poc Sep 10, 2024
31 of 32 checks passed
@romac romac deleted the joaotav/4084-multihop-packet-relaying branch September 10, 2024 15:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljoss17 ljoss17 ljoss17 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joaotav @ljoss17 @romac