Fix memo_overwrite configuration
#4103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
reviewed
Jul 29, 2024
crates/relayer/src/config.rs
Outdated
| @@ -3,6 +3,8 @@ | |||
| pub mod compat_mode; | |||
| pub mod dynamic_gas; | |||
| pub mod error; | |||
| /// TODO: Fix mutable_key_type warning | |||
| #[allow(clippy::mutable_key_type)] | |||
There was a problem hiding this comment.
Let's add this within the module itself.
romac
approved these changes
Jul 29, 2024
| @@ -18,6 +18,8 @@ fn test_filter_by_channel_incentivized_fees_relayer() -> Result<(), Error> { | |||
|
|
|||
| struct FilterIncentivizedFeesRelayerTest; | |||
|
|
|||
| /// TODO: Fix mutable_key_type warning | |||
| #[allow(clippy::mutable_key_type)] | |||
There was a problem hiding this comment.
Let's add this to the whole module.
ljoss17
changed the title
v1.80memo_overwrite configuration
romac
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4104
Description
This PR fixes clippy warnings and fixes the memo overwrite implementation as well as the test
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.