Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recv_packet relay #444

Merged
merged 15 commits into from
Dec 10, 2020
Merged

recv_packet relay #444

merged 15 commits into from
Dec 10, 2020

Conversation

ancazamfir
Copy link
Collaborator

@ancazamfir ancazamfir commented Dec 7, 2020 •
edited by adizere
Loading

Closes:
#443
and the recv_packet part of #379

Description

There main changes in this PR:

  • CLIs for recv_packet
  • relaying recv_packet from send_packet events from the relayer loop
  • implement limits on number of messages and size in send_msgs (used to be send_tx)
  • minimal changes to the modules' events (more work is required here)

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@codecov-io
Copy link

codecov-io commented Dec 7, 2020 •
edited
Loading

Codecov Report

Merging #444 (09005c9) into master (b1b37f5) will increase coverage by 23.4%.
The diff coverage is 67.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #444      +/-   ##
=========================================
+ Coverage    13.6%   37.0%   +23.4%     
=========================================
  Files          69     158      +89     
  Lines        3752   11928    +8176     
  Branches     1374    4729    +3355     
=========================================
+ Hits          513    4424    +3911     
- Misses       2618    6832    +4214     
- Partials      621     672      +51
Impacted Files Coverage Δ
modules/src/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/events.rs 0.0% <ø> (ø)
modules/src/ics02_client/msgs.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/raw.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/error.rs 13.6% <0.0%> (-19.7%) ⬇️
modules/src/ics04_channel/error.rs 75.0% <ø> (+50.0%) ⬆️
modules/src/ics04_channel/events.rs 0.0% <0.0%> (ø)
modules/src/ics04_channel/msgs/chan_close_init.rs 58.6% <ø> (ø)
modules/src/ics04_channel/msgs/chan_open_ack.rs 65.4% <ø> (ø)
...odules/src/ics04_channel/msgs/chan_open_confirm.rs 62.5% <ø> (ø)
... and 289 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e4f26...09005c9. Read the comment docs.

@ancazamfir ancazamfir self-assigned this Dec 7, 2020
adizere
adizere reviewed Dec 9, 2020
View reviewed changes
relayer/src/chain/cosmos.rs Outdated Show resolved Hide resolved
adizere
adizere reviewed Dec 9, 2020
View reviewed changes
relayer/src/chain/cosmos.rs Show resolved Hide resolved
relayer/src/chain/handle.rs Outdated Show resolved Hide resolved
relayer/src/foreign_client.rs Outdated Show resolved Hide resolved
adizere
adizere reviewed Dec 9, 2020
View reviewed changes
relayer/Cargo.toml Outdated Show resolved Hide resolved
adizere
adizere reviewed Dec 10, 2020
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of cool work, thanks Anca!

I'm not sure we should keep under revision the stores:

data0/05CB0CE74009F315AA79E2CE09E1CBE99EFEDDA3/snap.00000000000895FF
data1/9FDDAE8AEF9D908F044DCE9D5BB1DB71DFF1A2DD/snap.0000000000068EF6

And maybe also the gorly_config.toml could go in relayer-cli/tests/fixtures/ ?

Otherwise this looks ready.

@adizere adizere linked an issue Dec 10, 2020 that may be closed by this pull request
Packet CLIs for recv_packet #443
Closed
5 tasks
adizere
adizere approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~!

@adizere adizere merged commit 3a42c0c into master Dec 10, 2020
@adizere adizere deleted the anca/packet_relay branch December 10, 2020 17:48
@ancazamfir ancazamfir mentioned this pull request Dec 23, 2020
Closed
5 tasks
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@ancazamfir
recv_packet relay (informalsystems#444)
ba36c7d 
* packet CLIs

* recv packet relay from loop and CLIs

* Add limit on number of messages in a Tx, reorg the code

* add packet files

* fix rev event timestamp, change debug to info temporarily

* Streamline events, multi message Tx-es, cleanup

* Review comments, cleanup, validate events before processing in the relayer loop

* cargo fmt

* Remove files added by mistake in the last commit.

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@romac romac Awaiting requested review from romac

Assignees

@ancazamfir ancazamfir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packet CLIs for recv_packet
3 participants
@ancazamfir @codecov-io @adizere