Some cleanup (followup to protobuf dedup) #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master informalsystems/hermes#509 +/- ##
=========================================
+ Coverage 13.6% 41.1% +27.4%
=========================================
Files 69 133 +64
Lines 3752 8344 +4592
Branches 1374 0 -1374
=========================================
+ Hits 513 3434 +2921
- Misses 2618 4910 +2292
+ Partials 621 0 -621
Continue to review full report at Codecov.
|
|
@cezarad and @vitorenesduarte if you have a chance to look over this, any thoughts would be appreciated! |
romac
reviewed
Jan 18, 2021
Comment on lines
+265
to
+272
| // Verify that the error kind matches | ||
| if let Some(expected_kind) = test.error_kind { | ||
| assert_eq!( | ||
| &expected_kind, | ||
| e.kind(), | ||
| "conn_open_ack: expected error kind mismatches thrown error kind" | ||
| ) | ||
| } |
romac
approved these changes
Jan 18, 2021
ancazamfir
approved these changes
Jan 19, 2021
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* MsgConnectionOpenAck test cleanup * Quick fix for #513. * Better error msgs & frozen client check. * UPdated changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: cosmos/ibc-rs#107
Closes: cosmos/ibc-rs#96
Fixes for these two problems:
MsgConnectionOpenAck includes a new field counterparty_connection_id. Some minimal changes were done to handle this as part of Tendermint protobuf dependency for IBC proto #292 but tests need to be added. Also, the test infrastructure here is very hard to follow, maybe some cleanup would be nice
store_client_typeis never used and can be confusing (based on discussion with @CharlyCst) -- ClientType is never stored on 'create-client' cosmos/ibc-rs#96Deferred issues that will be handled later:
tendermint ClientState has new fields proof_specs that is currently ignored.-> will be handled together in Follow-up to migration work #469 (because it depends on re-enabling client tests)For contributor use:
docs/) and code comments.Files changedin the Github PR explorer.