-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relayer fixes after profiling #515
Conversation
Fix bugs uncovered by the faster execution :) Cleanup and some reorg for packet relay.
Simplify the code by adding a PacketMsgCollector and methods.
Codecov Report
@@ Coverage Diff @@
## master informalsystems/hermes#515 +/- ##
=========================================
+ Coverage 13.6% 29.4% +15.8%
=========================================
Files 69 161 +92
Lines 3752 13045 +9293
Branches 1374 5147 +3773
=========================================
+ Hits 513 3847 +3334
- Misses 2618 8947 +6329
+ Partials 621 251 -370
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, this is a lot cleaner 👍
This reverts commit 2c122a1.
* Replace runtime block_on with the util one where possible. * Fix bugs uncovered by the faster execution :) * Cleanup and some reorg for packet relay. * Add more event to tx result decoding. * Simplify the code by adding a PacketMsgCollector and methods. Co-authored-by: Adi Seredinschi <adi@informal.systems>
Closes: #514
Closes: cosmos/ibc-rs#135
Description
Main changes are:
CosmosSDK
'sblock_on()
with util'sblock_on()
build_update_client()
to wait for source chain to reach thetarget_height
PacketMsgCollector
that is populated by the queries, with focus on correct query height versus proof and client update height.Miscellaneous/ Cleanup:
Msg
'svalidate_basic()
For contributor use:
docs/
) and code comments.Files changed
in the Github PR explorer.