Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relayer fixes after profiling #515

Merged
merged 16 commits into from
Jan 15, 2021
Merged

Relayer fixes after profiling #515

merged 16 commits into from
Jan 15, 2021

Conversation

ancazamfir
Copy link
Collaborator

@ancazamfir ancazamfir commented Jan 12, 2021

Closes: #514
Closes: cosmos/ibc-rs#135

Description

Main changes are:

  • replaced CosmosSDK 's block_on() with util's block_on()
  • added check in build_update_client() to wait for source chain to reach the target_height
  • re-organized packet CLIs around PacketMsgCollector that is populated by the queries, with focus on correct query height versus proof and client update height.

Miscellaneous/ Cleanup:

  • added ack and timeout event extraction from Tx results
  • removed Msg 's validate_basic()

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

Fix bugs uncovered by the faster execution :)

Cleanup and some reorg for packet relay.
Simplify the code by adding a PacketMsgCollector and methods.
@codecov-io
Copy link

codecov-io commented Jan 12, 2021

Codecov Report

Merging #515 (552f9fd) into master (b1b37f5) will increase coverage by 15.8%.
The diff coverage is 56.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    informalsystems/hermes#515      +/-   ##
=========================================
+ Coverage    13.6%   29.4%   +15.8%     
=========================================
  Files          69     161      +92     
  Lines        3752   13045    +9293     
  Branches     1374    5147    +3773     
=========================================
+ Hits          513    3847    +3334     
- Misses       2618    8947    +6329     
+ Partials      621     251     -370     
Impacted Files Coverage Δ
...application/ics20_fungible_token_transfer/error.rs 0.0% <0.0%> (ø)
...pplication/ics20_fungible_token_transfer/events.rs 0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs 0.0% <0.0%> (ø)
modules/src/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/msgs.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/raw.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/error.rs 12.5% <0.0%> (-20.9%) ⬇️
modules/src/ics03_connection/events.rs 0.0% <0.0%> (ø)
modules/src/ics04_channel/error.rs 75.0% <ø> (+50.0%) ⬆️
... and 283 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eda47b...09e7817. Read the comment docs.

@ancazamfir ancazamfir marked this pull request as ready for review January 12, 2021 18:21
relayer/src/link.rs Outdated Show resolved Hide resolved
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, this is a lot cleaner 👍

relayer/src/link.rs Outdated Show resolved Hide resolved
relayer/src/foreign_client.rs Outdated Show resolved Hide resolved
relayer-cli/src/commands/query/packet.rs Outdated Show resolved Hide resolved
relayer/src/chain/cosmos.rs Show resolved Hide resolved
relayer/src/link.rs Show resolved Hide resolved
@adizere adizere mentioned this pull request Jan 15, 2021
5 tasks
@ancazamfir ancazamfir merged commit daeb8dc into master Jan 15, 2021
@ancazamfir ancazamfir deleted the anca/relayer_profiling branch January 15, 2021 14:03
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Replace runtime block_on with the util one where possible.

* Fix bugs uncovered by the faster execution :)

* Cleanup and some reorg for packet relay.

* Add more event to tx result decoding.

* Simplify the code by adding a PacketMsgCollector and methods.

Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poor performance for Tx-es and queries
4 participants