Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tokio to 1.0, Prost to 0.7 and Tonic to 0.4 #534

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Conversation

romac
Copy link
Member

@romac romac commented Jan 18, 2021

Closes: #527

Description

Update Tokio to 1.0, Prost to 0.7 and Tonic to 0.4.

Depends on informalsystems/tendermint-rs#783.


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@codecov-io
Copy link

codecov-io commented Jan 18, 2021

Codecov Report

Merging #534 (13cb248) into master (b1b37f5) will increase coverage by 27.3%.
The diff coverage is 69.2%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #534      +/-   ##
=========================================
+ Coverage    13.6%   41.0%   +27.3%     
=========================================
  Files          69     133      +64     
  Lines        3752    8315    +4563     
  Branches     1374       0    -1374     
=========================================
+ Hits          513    3415    +2902     
- Misses       2618    4900    +2282     
+ Partials      621       0     -621     
Impacted Files Coverage Δ
...application/ics20_fungible_token_transfer/error.rs 0.0% <0.0%> (ø)
...pplication/ics20_fungible_token_transfer/events.rs 0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs 0.0% <0.0%> (ø)
modules/src/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/error.rs 100.0% <ø> (ø)
modules/src/ics02_client/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/raw.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/error.rs 100.0% <ø> (+66.6%) ⬆️
modules/src/ics03_connection/events.rs 0.0% <0.0%> (ø)
modules/src/ics04_channel/error.rs 100.0% <ø> (+75.0%) ⬆️
... and 228 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 133524a...68dc670. Read the comment docs.

@romac romac marked this pull request as ready for review January 19, 2021 11:39
@romac romac requested a review from adizere January 19, 2021 11:39
Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It will be interesting to see if we can move back to self.block_on() without the performance issues.

@romac romac merged commit 1a77c0a into master Jan 19, 2021
@romac romac deleted the romac/update-tokio branch January 19, 2021 11:48
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Update Tokio to 1.0, Prost to 0.7 and Tonic to 0.4

* Point to tendermint-rs `ibc` branch

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade deps to Tokio 1.0
3 participants