Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on tendermint-rpc in the ibc crate #639

Merged
merged 4 commits into from
Feb 12, 2021

Conversation

romac
Copy link
Member

@romac romac commented Feb 11, 2021

Closes: cosmos/ibc-rs#90

Description

Remove dependency on tendermint-rpc in the ibc crate by moving get_all_events into the ibc-relayer crate.


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac added this to the v0.1.1 milestone Feb 11, 2021
@romac romac requested review from adizere and ancazamfir February 11, 2021 16:14
@codecov-io
Copy link

codecov-io commented Feb 11, 2021

Codecov Report

Merging #639 (0bcfafd) into master (b1b37f5) will increase coverage by 32.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    informalsystems/hermes#639      +/-   ##
=========================================
+ Coverage    13.6%   46.1%   +32.4%     
=========================================
  Files          69     149      +80     
  Lines        3752   10028    +6276     
  Branches     1374       0    -1374     
=========================================
+ Hits          513    4628    +4115     
- Misses       2618    5400    +2782     
+ Partials      621       0     -621     
Impacted Files Coverage Δ
modules/src/address.rs 100.0% <ø> (ø)
...application/ics20_fungible_token_transfer/error.rs 0.0% <ø> (ø)
...pplication/ics20_fungible_token_transfer/events.rs 0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs 0.0% <ø> (ø)
modules/src/events.rs 0.0% <ø> (ø)
modules/src/handler.rs 100.0% <ø> (ø)
modules/src/ics02_client/client_def.rs 48.3% <ø> (ø)
modules/src/ics02_client/client_type.rs 79.1% <ø> (+31.5%) ⬆️
modules/src/ics02_client/context.rs 100.0% <ø> (ø)
modules/src/ics02_client/error.rs 100.0% <ø> (ø)
... and 255 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47e1776...0bcfafd. Read the comment docs.

@romac romac force-pushed the romac/remove-rpc-dep branch from b6f54ba to 0bcfafd Compare February 12, 2021 08:54
Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Romain!

@ancazamfir ancazamfir merged commit ca33863 into master Feb 12, 2021
@ancazamfir ancazamfir deleted the romac/remove-rpc-dep branch February 12, 2021 09:07
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
…ms#639)

* Remove dependency on tendermint-rpc in the `ibc` crate

* Fix doc comments

* Fixup changelog

Co-authored-by: Anca Zamfir <zamfiranca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants