Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto-compiler: Make ibc-go repo optional #808

Merged
merged 10 commits into from
Apr 8, 2021
Merged

Conversation

adizere
Copy link
Member

@adizere adizere commented Apr 8, 2021

Closes #809
Changes in this PR:

  • made the parameters --ibc-go-commit (for clone command) and --ibc (for compile command) optional
  • regenerated the Rust files for IBC from the SDK .proto files (ignoring the IBC go repo)

Description


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@adizere adizere requested review from ancazamfir and romac as code owners April 8, 2021 15:36
@ancazamfir
Copy link
Collaborator

Tried to run dev-env:

$ cargo build -q
error: couldn't read proto/src/prost/COSMOS_IBC_COMMIT: No such file or directory (os error 2)
  --> proto/src/lib.rs:13:38
   |
13 | pub const COSMOS_IBC_VERSION: &str = include_str!("prost/COSMOS_IBC_COMMIT");
   |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to previous error

error: could not compile `ibc-proto`

To learn more, run the command again with --verbose.
ancas-mbp:ibc-rs ancaz$

@codecov-io
Copy link

Codecov Report

Merging #808 (9513ede) into master (b1b37f5) will increase coverage by 31.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #808      +/-   ##
=========================================
+ Coverage    13.6%   45.0%   +31.3%     
=========================================
  Files          69     164      +95     
  Lines        3752   11299    +7547     
  Branches     1374       0    -1374     
=========================================
+ Hits          513    5090    +4577     
- Misses       2618    6209    +3591     
+ Partials      621       0     -621     
Impacted Files Coverage Δ
...application/ics20_fungible_token_transfer/error.rs 0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs 22.2% <ø> (ø)
..._transfer/relay_application_logic/send_transfer.rs 85.7% <ø> (ø)
modules/src/events.rs 0.0% <ø> (ø)
modules/src/handler.rs 100.0% <ø> (ø)
modules/src/ics02_client/client_consensus.rs 55.8% <ø> (ø)
modules/src/ics02_client/client_def.rs 32.3% <ø> (ø)
modules/src/ics02_client/client_state.rs 65.1% <ø> (ø)
modules/src/ics02_client/client_type.rs 79.1% <ø> (+31.5%) ⬆️
modules/src/ics02_client/context.rs 90.4% <ø> (ø)
... and 251 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c72c28...9513ede. Read the comment docs.

@ancazamfir ancazamfir merged commit 227c079 into master Apr 8, 2021
@ancazamfir ancazamfir deleted the adi/ibc_proto_undo branch April 8, 2021 20:21
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Fix incorrect path bug for IBC Go

* Fix for clone command to assume optional IBC go repo

* Fix for compile.rs

* Regenerated rust files

* Readme update

* Upgrade to gaia v4.2.0

* Update changelog

* Updating files for gaia v4.2.0 (informalsystems#808)

* Updating instructions (informalsystems#808)

Co-authored-by: Anca Zamfir <zamfiranca@gmail.com>
Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade CI to gaia v4.2.0
5 participants