-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proto-compiler: Make ibc-go repo optional #808
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
approved these changes
Apr 8, 2021
Tried to run
|
Codecov Report
@@ Coverage Diff @@
## master #808 +/- ##
=========================================
+ Coverage 13.6% 45.0% +31.3%
=========================================
Files 69 164 +95
Lines 3752 11299 +7547
Branches 1374 0 -1374
=========================================
+ Hits 513 5090 +4577
- Misses 2618 6209 +3591
+ Partials 621 0 -621
Continue to review full report at Codecov.
|
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Fix incorrect path bug for IBC Go * Fix for clone command to assume optional IBC go repo * Fix for compile.rs * Regenerated rust files * Readme update * Upgrade to gaia v4.2.0 * Update changelog * Updating files for gaia v4.2.0 (informalsystems#808) * Updating instructions (informalsystems#808) Co-authored-by: Anca Zamfir <zamfiranca@gmail.com> Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #809
Changes in this PR:
--ibc-go-commit
(forclone
command) and--ibc
(forcompile
command) optionalDescription
For contributor use:
docs/
) and code comments.Files changed
in the Github PR explorer.