Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set allow_update_..flags in client state to true #828

Merged
merged 5 commits into from
Apr 16, 2021

Conversation

ancazamfir
Copy link
Collaborator

Get clock drift from configuration

Closes: #785

Description

  • set allow_update_..flags in tendermint client state builder totrue`
  • get the clock drift from config

Note: the build_client_state() should eventually become parameterized once we allow parameters in hermes create client. This will be done in another PR.


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

Get clock drift from configuration
@ancazamfir ancazamfir requested a review from romac as a code owner April 15, 2021 14:16
@codecov-io
Copy link

Codecov Report

Merging #828 (0c4e737) into master (b1b37f5) will increase coverage by 29.8%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #828      +/-   ##
=========================================
+ Coverage    13.6%   43.5%   +29.8%     
=========================================
  Files          69     170     +101     
  Lines        3752   12651    +8899     
  Branches     1374       0    -1374     
=========================================
+ Hits          513    5508    +4995     
- Misses       2618    7143    +4525     
+ Partials      621       0     -621     
Impacted Files Coverage Δ
...application/ics20_fungible_token_transfer/error.rs 0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs 22.2% <ø> (ø)
..._transfer/relay_application_logic/send_transfer.rs 85.7% <ø> (ø)
modules/src/events.rs 0.0% <ø> (ø)
modules/src/handler.rs 100.0% <ø> (ø)
modules/src/ics02_client/client_consensus.rs 41.3% <ø> (ø)
modules/src/ics02_client/client_def.rs 31.6% <ø> (ø)
modules/src/ics02_client/client_state.rs 65.1% <ø> (ø)
modules/src/ics02_client/client_type.rs 79.1% <ø> (+31.5%) ⬆️
modules/src/ics02_client/context.rs 95.0% <ø> (ø)
... and 245 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f5116...0c4e737. Read the comment docs.

@ancazamfir ancazamfir merged commit f993e25 into master Apr 16, 2021
@ancazamfir ancazamfir deleted the anca/tm_allow_update_true branch April 23, 2021 12:46
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Set allow_update_..flags in client state to `true`

* Get clock drift from configuration

* Introduce AllowUpdate struct to help with boolean blindness

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create clients with allow_update_after_... flags set to true by default
3 participants