Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for empty Tx response when querying packet events #852

Merged
merged 3 commits into from
Apr 26, 2021

Conversation

ancazamfir
Copy link
Collaborator

@ancazamfir ancazamfir commented Apr 26, 2021

Closes: #851

Description


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@ancazamfir ancazamfir requested a review from romac as a code owner April 26, 2021 18:16
@ancazamfir ancazamfir requested a review from adizere April 26, 2021 18:16
@codecov-commenter
Copy link

Codecov Report

Merging #852 (68e2c35) into master (9f2c7cb) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #852     +/-   ##
========================================
- Coverage    43.5%   43.5%   -0.1%     
========================================
  Files         170     170             
  Lines       12646   12648      +2     
========================================
  Hits         5512    5512             
- Misses       7134    7136      +2     
Impacted Files Coverage Δ
relayer/src/chain/cosmos.rs 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f2c7cb...68e2c35. Read the comment docs.

Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, neat fix!

Managed to recreate the bug locally and the fix is good.

@adizere adizere merged commit 2497f87 into master Apr 26, 2021
@adizere adizere deleted the anca/851_crash_fix branch April 26, 2021 18:48
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
…ems#852)

* Check for empty Tx response when querying packets

* Update changelog

* Fix typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hermes crashes on clear packets when full node indexing
3 participants