Fix crash during initialization of event monitor when node is down #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like the WebSocketClient does not notify us when the connection goes down so we cannot print a warning and try to reconnect. Will investigate and open an issue on tendermint-rs. |
ancazamfir
reviewed
May 6, 2021
Comment on lines
+406
to
+407
| let span = error_span!("worker loop", worker = %self); | ||
| let _guard = span.enter(); |
ancazamfir
approved these changes
May 6, 2021
5 tasks
This was referenced Jun 1, 2021
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…nformalsystems#895) * Introduce error type for event monitor * Do not crash if chain runtime fails to subscribe to events * Gracefully handle runtime init error in `start-multi` command * Improve worker error context * Fix chain id in error message if spawning chain runtime fails * Print channel error when one arises * Refactor event monitor loop a little bit * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #863
Description
Follow-up
WebSocketClientdoes not notify us when the connection goes down so we cannot print a warning and try to reconnect. Will investigate and open an issue on tendermint-rs.For contributor use:
docs/) and code comments.Files changedin the Github PR explorer.