Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for timeout timestamp #938

Merged
merged 9 commits into from
May 14, 2021
Merged

Add support for timeout timestamp #938

merged 9 commits into from
May 14, 2021

Conversation

ancazamfir
Copy link
Collaborator

@ancazamfir ancazamfir commented May 14, 2021 •
edited
Loading

Closes: #937

Description

  • added -o and -t options to ft-transfer for height and time offset
  • decode timeout_timestamp event attribute
  • changed relayer to relay recv_packet before timeout
  • updated guide

Testing done:

  • used ft-transfer with -t set to small and higher values to cover both timestamp based timeouts and successful recv packets. Do this for:
    • packet clearing (i.e. first issue the commands and then start-multi)
    • active packet relaying (i.e. first start-multi and then issue the commands)
    • both
  • same as above with -o
  • also tested with liquidityd CLI

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

romac
romac approved these changes May 14, 2021
View reviewed changes
relayer/src/transfer.rs
Comment on lines +62 to +64
Timestamp::from_nanoseconds(
Timestamp::now().as_nanoseconds() + opts.timeout_seconds.as_nanos() as u64,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #942 to improve this.

@ancazamfir ancazamfir merged commit 3900e42 into master May 14, 2021
@ancazamfir ancazamfir deleted the anca/timeout_timestamp branch May 14, 2021 10:35
@ancazamfir ancazamfir mentioned this pull request May 25, 2021
Closed
5 tasks
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@ancazamfir @romac
Add support for timeout timestamp (informalsystems#938)
f9bda87 
* Decode the timestamp from Tx events, relay timestamp timeouts

* Add timeout timestamp option to ft-transfer

* Fix e2e scripts.

* Update guide

* Define none() for timestamp

* Update changelog

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@adizere adizere Awaiting requested review from adizere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for packet timeout based on the timeout_timestamp
2 participants
@ancazamfir @romac