Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote start-multi to start #971

Merged
merged 6 commits into from
May 25, 2021
Merged

Promote start-multi to start #971

merged 6 commits into from
May 25, 2021

Conversation

romac
Copy link
Member

@romac romac commented May 21, 2021 •
edited
Loading

Closes: #911

Description

  • Promote start-multi command to start
  • Remove start command
  • Remove dead code that was only used by previous start command
  • Update CI

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac added this to the 05.2021 milestone May 21, 2021
@romac romac marked this pull request as ready for review May 21, 2021 13:22
@romac romac requested review from adizere and ancazamfir as code owners May 21, 2021 13:22
adizere
adizere approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

relayer/src/link.rs Show resolved Hide resolved
ancazamfir
ancazamfir approved these changes May 25, 2021
View reviewed changes
Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Romain!

@ancazamfir ancazamfir merged commit 1f498e3 into master May 25, 2021
@ancazamfir ancazamfir deleted the romac/promote-start-multi branch May 25, 2021 08:05
@adizere adizere mentioned this pull request Jun 1, 2021
Merged
9 tasks
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@romac
Promote start-multi to start (informalsystems#971)
d462445 
* Promote `start-multi` command to `start`

* Cleanup ForeignClient::restore

* Remove unused `relayer::relay` module

* Remove unused `Link::relay` method

* Update e2e test suite

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancazamfir ancazamfir ancazamfir approved these changes

@adizere adizere adizere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
05.2021
Development

Successfully merging this pull request may close these issues.

Deprecate hermes start
3 participants
@romac @adizere @ancazamfir