Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker release fix #973

Merged
merged 6 commits into from
May 21, 2021
Merged

Docker release fix #973

merged 6 commits into from
May 21, 2021

Conversation

greg-szabo
Copy link
Member

@greg-szabo greg-szabo commented May 21, 2021 •
edited
Loading

Closes: #967

Description

Fix for the Docker Hub release
Now it's tested properly.

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@greg-szabo greg-szabo changed the title WIP docker fix with test Docker release fix May 21, 2021
romac
romac approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @greg-szabo :)

@romac romac merged commit 5d654d9 into master May 21, 2021
@romac romac deleted the greg/docker-release-fix branch May 21, 2021 16:07
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@greg-szabo
Fix for the Docker Hub release job (informalsystems#973)
b70393e 
* docker fix with test

* docker fix 2

* docker fix 3

* docker fix version prefix

* docker fix test

* Removed test workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@adizere adizere Awaiting requested review from adizere

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker Hub image auto-release
2 participants
@greg-szabo @romac