Fixes after testing with GM #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ancazamfir
reviewed
May 24, 2021
relayer/src/supervisor.rs
Outdated
| @@ -273,6 +273,11 @@ impl Supervisor { | |||
| } | |||
| } | |||
|
|
|||
| // At least one chain runtime should be alive and kicking, otherwise bail. | |||
There was a problem hiding this comment.
funny comment but what does it mean exactly?
There was a problem hiding this comment.
I meant to say that if the vector of chain runtimes (self.registry) is empty, that means no chain runtime could be instantiated, so the supervisor (i) cannot spawn any worker and (ii) has no subscription to any chain to select on. I'll use more accurate language here!
There was a problem hiding this comment.
also #972 (comment)
I am not able to see that panic. What are the steps to see that? I tried to start hermes without any chains started and also tried to kill the chain procs while hermes is running.
7 tasks
ancazamfir
approved these changes
May 25, 2021
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Fix panic when all chains are unreachable * Fix for reverse params in client worker. * FMT fix * Removed useseless format * Better comment. Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #972
Description
For contributor use:
docs/) and code comments.Files changedin the Github PR explorer.