Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gm hermes keys command when hdpath is set #976

Merged
merged 6 commits into from
May 28, 2021
Merged

Fix gm hermes keys command when hdpath is set #976

merged 6 commits into from
May 28, 2021

Conversation

greg-szabo
Copy link
Member

Closes: #975

Description

  • Fixes gm hermes keys command when the wallet_hdpath contains a non-default coin type.
  • Adds a changelog to the gm tool for easier tracking.
  • bumps version to 0.0.2

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

romac
romac reviewed May 25, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
romac
romac reviewed May 25, 2021
View reviewed changes
scripts/gm/CHANGELOG.md Outdated Show resolved Hide resolved
@romac
Copy link
Member

romac commented May 25, 2021 •
edited
Loading

Do we want the keys add command to take an option to specify the full hd path rather than just the coin type? Or is the latter fine for now?

@greg-szabo
Copy link
Member Author

Fine for now. I'll open a hermes ticket if we realize we need the full HD path in Hermes.

greg-szabo and others added 4 commits May 25, 2021 09:13
@greg-szabo
Merge branch 'master' into greg/gm-hermes-hdpath-fix
a4de37f
@greg-szabo
Merge branch 'master' into greg/gm-hermes-hdpath-fix
3a2744b
@greg-szabo @romac
Update CHANGELOG.md
6fcd0eb 
Co-authored-by: Romain Ruetschi <romain@informal.systems>
@greg-szabo @romac
Update scripts/gm/CHANGELOG.md
e829611 
Co-authored-by: Romain Ruetschi <romain@informal.systems>
@greg-szabo greg-szabo requested a review from romac May 28, 2021 00:50
@greg-szabo greg-szabo merged commit ef85be3 into master May 28, 2021
@greg-szabo greg-szabo deleted the greg/gm-hermes-hdpath-fix branch May 28, 2021 14:18
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@greg-szabo @romac
Fix gm hermes keys command when hdpath is set (informalsystems#976)
dda2713 
* Fix gm hermes keys command when hdpath is set

* Update CHANGELOG.md

Co-authored-by: Romain Ruetschi <romain@informal.systems>

* Update scripts/gm/CHANGELOG.md

Co-authored-by: Romain Ruetschi <romain@informal.systems>

* Updated stoml required version

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir ancazamfir approved these changes

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gm tool imports wrong keys into hermes when hdpath is set
4 participants
@greg-szabo @romac @adizere @ancazamfir