Skip to content
This repository has been archived by the owner on Mar 5, 2021. It is now read-only.

Fix clash between re-exported modules causing glitches in documentation #9

Merged
merged 7 commits into from
Sep 15, 2020

Conversation

romac
Copy link
Member

@romac romac commented Sep 15, 2020

Close #8

Since this PR changes the public API exported by this library, it likely warrants a major version bump for the next release (eg. v0.3.0).


  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

@romac romac requested review from andynog and greg-szabo and removed request for andynog September 15, 2020 09:00
@romac romac mentioned this pull request Sep 15, 2020
5 tasks
greg-szabo
greg-szabo previously approved these changes Sep 15, 2020
Base automatically changed from andy/update-protos to master September 15, 2020 15:03
@romac romac dismissed greg-szabo’s stale review September 15, 2020 15:03

The base branch was changed.

@romac romac requested a review from greg-szabo September 15, 2020 15:05
Copy link
Contributor

@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changes look good.

@romac romac merged commit b7075b9 into master Sep 15, 2020
@romac romac deleted the romac/fix-docs branch September 15, 2020 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clash between re-exported modules breaks documentation
3 participants