Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermes should retry on TxNoConfirmation error #1124

Closed
7 tasks
ancazamfir opened this issue Jun 23, 2021 · 0 comments · Fixed by #1278
Closed
7 tasks

Hermes should retry on TxNoConfirmation error #1124

ancazamfir opened this issue Jun 23, 2021 · 0 comments · Fixed by #1278
Assignees
Labels
A: bug Admin: something isn't working
Milestone

Comments

@ancazamfir
Copy link
Collaborator

ancazamfir commented Jun 23, 2021

Crate

relayer

Summary of Bug

hermes should retry below on TxNoConfirmation (in addition to the retry for ChainError further down)
https://github.com/informalsystems/ibc-rs/blob/d41f7fa5c0923ebcd5e3c8f62ec469ad5b1c335f/relayer/src/link.rs#L742

Version

v0.5.0, master

Steps to Reproduce

tbd, i expect if we make the number of retries for retrieving the Tx to something like 2 we should be able to reproduce this locally.
The problem was seen in a debug session for unrelayed packets on cosmoshub-4 - osmosis-1 channel. hermes start should have cleared the packets but after the TxNoConfirmation error it was giving up.

Acceptance Criteria

  • add smoother retry mechanism to prevent missed packets
  • fix error in log ERROR [cosmoshub-4] error during batch processing: missing chain for id (osmosis-1) in configuration file by filtering out batches (e.g., using a method on CollectedEvents) if their destination chain is not specified in the configuration file

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir added this to the 06.2021 milestone Jun 23, 2021
@romac romac changed the title hermes should retry on TxNoConfirmation error Hermes should retry on TxNoConfirmation error Jun 25, 2021
@adizere adizere added the A: bug Admin: something isn't working label Jul 1, 2021
@adizere adizere modified the milestones: 06.2021, 07.2021 Jul 12, 2021
@adizere adizere modified the milestones: 07.2021, 08.2021 Aug 3, 2021
@romac romac mentioned this issue Aug 18, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
None yet
2 participants