Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identifiers limit update #168

Closed
4 tasks done
adizere opened this issue Jul 24, 2020 · 0 comments · Fixed by #189
Closed
4 tasks done

Identifiers limit update #168

adizere opened this issue Jul 24, 2020 · 0 comments · Fixed by #189
Assignees
@adizere @andynog
Labels
I: spec Internal: related to IBC specifications
Milestone
v.0.0.3

Comments

@adizere
Copy link
Member

adizere commented Jul 24, 2020 •
edited
Loading

Summary of Bug

The canonical ICS 024 was recently updated with new limits on identifiers lengths.

cosmos/ibc@b89ef9e#diff-0bbd628bc227e2b5cc0bb69381d42362

Related PR in the SDK: cosmos/cosmos-sdk#6812

We should reflect this update in our implementation.

Version

Steps to Reproduce

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added I: spec Internal: related to IBC specifications ibc-ics labels Jul 24, 2020
@adizere adizere added this to the v.0.0.3 milestone Jul 24, 2020
@adizere adizere self-assigned this Jul 24, 2020
@andynog andynog self-assigned this Jul 31, 2020
andynog added a commit that referenced this issue Jul 31, 2020
@andynog
Fixed the identifiers limits according to updated ics spec. Added val…
6574b5d 
…idation tests. #168
@andynog andynog mentioned this issue Jul 31, 2020
Merged
6 tasks
greg-szabo pushed a commit that referenced this issue Jul 31, 2020
@andynog
Fixed the identifiers limits according to updated ics spec (#189)
acba7ad 
* Fixed the identifiers limits according to updated ics spec. Added validation tests. #168

* Fixing test cases after limit updates #189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adizere adizere

@andynog andynog

Labels
I: spec Internal: related to IBC specifications
Projects
None yet
Milestone
v.0.0.3
Development

Successfully merging a pull request may close this issue.

Fixed the identifiers limits according to updated ics spec informalsystems/hermes
2 participants
@adizere @andynog