Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handlers should use host's latest block's timestamp instead of host's timestamp #57

Closed
6 tasks
hu55a1n1 opened this issue Jan 14, 2022 · 0 comments · Fixed by informalsystems/hermes#1771
Closed
6 tasks

Handlers should use host's latest block's timestamp instead of host's timestamp #57

hu55a1n1 opened this issue Jan 14, 2022 · 0 comments · Fixed by informalsystems/hermes#1771
Assignees
@hu55a1n1
Labels
A: bug Admin: something isn't working

Comments

@hu55a1n1
Copy link
Contributor

hu55a1n1 commented Jan 14, 2022 •
edited
Loading

Crate

ibc

Summary of Bug

ChannelReader::host_timestamp() gets the host's timestamp to do calculations (eg. verify packet delay elapsed and check packet hasn't expired). The problem with this approach is that the host's timestamp is non-deterministic and may vary from one full node to another. ibc-go seems to solve this by using the block time of the latest block on-chain.

Version

master

Acceptance Criteria

  • Handlers use the latest on-chain blocks timestamp.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned

PS: Many thanks to @ancazamfir for helping find this bug.
@hu55a1n1 hu55a1n1 self-assigned this Jan 14, 2022
@hu55a1n1 hu55a1n1 added the A: bug Admin: something isn't working label Jan 14, 2022
This was referenced Jan 14, 2022
Merged
Merged
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
@ethanfrey
Merge pull request cosmos#57 from roysc/add-smt-spec
606d510 
Add `SmtSpec` for SMT proofs
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
@webmaster128
Add missing comma
fd2ba74 
Fixes a collision between cosmos#72 and cosmos#57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hu55a1n1 hu55a1n1

Labels
A: bug Admin: something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deterministic host timestamp informalsystems/hermes
1 participant
@hu55a1n1