Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup exported types in channel #120

Closed
adizere opened this issue Aug 3, 2020 · 0 comments
Closed

Cleanup exported types in channel #120

adizere opened this issue Aug 3, 2020 · 0 comments

Comments

@adizere
Copy link
Contributor

adizere commented Aug 3, 2020

The exported module brings up a related problem I believe. Parts of this module (and its intended functionality) may be unnecessary and we can remove it..

yes, we should remove the traits from the exported.rs files (in both connection and channel folders).

Originally posted by @ancazamfir in informalsystems/hermes#186 (comment)

More specifically, the traits Channel and ChannelCounterparty can be removed:

https://github.com/informalsystems/ibc-rs/blob/6f89b2ddbd16c3b7b77476a0ef0683b5f531fe14/modules/src/ics04_channel/exported.rs#L6-L22
@c410-f3r c410-f3r mentioned this issue Aug 11, 2020
Merged
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
livelybug pushed a commit to octopus-network/ibc-rs that referenced this issue Oct 14, 2022
@ancazamfir @ebuchman @adizere
Release 0.0.1 of ibc-rs (cosmos#120)
6eccc5e 
* Added CHANGELOG.md

* Apply suggestions from code review

Co-authored-by: Adi Seredinschi <adi@informal.systems>

* update changes

Co-authored-by: Ethan Buchman <ethan@coinculture.info>
Co-authored-by: Adi Seredinschi <adi@informal.systems>
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
@romac
ci: Refactor GitHub workflows and add code coverage job (cosmos#120)
4232e6c 
* Split GitHub Actions definitions per language

* Add code coverage job for Rust crate

* Trigger CI run

* Fix Rust coverage job

* Fix Rust coverage job, take 2

* Add badges to README

* See if all statuses are reported this way

* Revert "See if all statuses are reported this way"

This reverts commit 02b9df50bacc68389bd5bfb99cbf7a1eb94a9b76.

* Add code coverage job for Go library

* Add names to Rust jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adizere