Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate hermes start #911

Closed
5 tasks
ancazamfir opened this issue May 6, 2021 · 0 comments · Fixed by #971
Closed
5 tasks

Deprecate hermes start #911

ancazamfir opened this issue May 6, 2021 · 0 comments · Fixed by #971
Labels
I: CLI Internal: related to the relayer's CLI
Milestone

Comments

@ancazamfir
Copy link
Collaborator

Crate

relayer

Summary

  • deprecate hermes start and rename start-multi to start:
    • hermes start same as hermes start-multi, relays all packets for all configured chains
    • hermes start --chain-a <chain-a-id> --chain-b <chain-b-id> -> MAYBE (just because it makes sense with the granularity progression here)
    • hermes start --chain <chain-id> --connection <connection-id> relay packets and channel handshake over the specified connection (do not do connection handshake, it must be opened at some point through other means for this to do anything) -> Agoric requirement
    • hermes start --chain <chain-id> --port <port-id> --channel <channel-id> (similar as above, no channel handshake) -> to replace current hermes start <chain-id> -p <port-id> -c <channel-id>
  • config should still include only chains
  • rethink config strategy, maybe packets to relay only packets and all to also do handshake on all the commands above.

Problem Definition

Proposal

Acceptance Criteria


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir added this to the 05.2021 milestone May 6, 2021
@romac romac added the I: CLI Internal: related to the relayer's CLI label May 12, 2021
@romac romac mentioned this issue May 21, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: CLI Internal: related to the relayer's CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants