Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for packet timeout based on the timeout_timestamp #937

Closed
5 tasks done
ancazamfir opened this issue May 14, 2021 · 0 comments · Fixed by #938
Closed
5 tasks done

Add support for packet timeout based on the timeout_timestamp #937

ancazamfir opened this issue May 14, 2021 · 0 comments · Fixed by #938
Assignees
Labels
E: gravity External: related to Gravity DEX I: CLI Internal: related to the relayer's CLI I: logic Internal: related to the relaying logic
Milestone

Comments

@ancazamfir
Copy link
Collaborator

Crate

relayer, relayer-cli

Summary

DEX's liquidityd is using timestamp timeouts for packets.

Problem Definition

hermes lacks support for timeout based on packet the timeout timestamp. In addition, it fails to extract the timestamp when querying Tx-es resulting in relay failures for recv-packet -s even if the packets are not timed out.

Proposal

  • decode the timeout_timestamp from query_txs() result
  • add option to set the timeout_timestamp in ft-transfer CLI

Acceptance Criteria

  • hermes can relay packets with none, one or both timeout fields set (timeout_height and timeout_timestamp)
  • hermes can timeout packets based on timestamp
  • means to test this behaviour is provided via the hermes ft-transfer CLI

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir added I: CLI Internal: related to the relayer's CLI I: logic Internal: related to the relaying logic E: gravity External: related to Gravity DEX labels May 14, 2021
@ancazamfir ancazamfir added this to the 05.2021 milestone May 14, 2021
@ancazamfir ancazamfir self-assigned this May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: gravity External: related to Gravity DEX I: CLI Internal: related to the relayer's CLI I: logic Internal: related to the relaying logic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant