Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(driver): Simplify code to keep only one round state #71

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

romac
Copy link
Member

@romac romac commented Nov 14, 2023

No description provided.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8654e59) 87.50% compared to head (cbb27a6) 87.04%.

Files Patch % Lines
Code/driver/src/driver.rs 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   87.50%   87.04%   -0.46%     
==========================================
  Files          30       30              
  Lines        1296     1281      -15     
==========================================
- Hits         1134     1115      -19     
- Misses        162      166       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romac romac changed the title Simplify code to keep only one round state feat(driver): Simplify code to keep only one round state Nov 14, 2023
@romac romac marked this pull request as ready for review November 15, 2023 11:06
Base automatically changed from anca/vote_height to main November 15, 2023 15:34
@romac romac force-pushed the anca/one_round_state branch from 8db3707 to a9ea037 Compare November 15, 2023 15:42
@romac
Copy link
Member Author

romac commented Nov 16, 2023

Looks good to me!

@josef-widder @cason Do you foresee any issues with only keeping the state of consensus state machine for the current round?

@josef-widder
Copy link
Member

Looks good to me!

@josef-widder @cason Do you foresee any issues with only keeping the state of consensus state machine for the current round?

I think that's OK, as it matches the arxiv description and the quint model. The point is that the messages for past rounds might still be needed, but as far as I see they are not in RoundState.

@romac romac merged commit 0ea4ce9 into main Nov 17, 2023
7 checks passed
@romac romac deleted the anca/one_round_state branch November 17, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants