feat(code/app/starknet): Adapt Starknet app to latest P2P protos

[romac]

Closes: #XXX

---

PR author checklist

For all contributors

• Reference GitHub issue
• Ensure PR title follows the conventional commits spec

For external contributors

• Maintainers of Malachite are allowed to push changes to the branch

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.87%. Comparing base (614a46c) to head (da0334b).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
+ Coverage   75.79%   75.87%   +0.08%     
==========================================
  Files         169      172       +3     
  Lines       14682    14785     +103     
==========================================
+ Hits        11128    11218      +90     
- Misses       3554     3567      +13     

Flag	Coverage Δ
integration	75.59% <ø> (+0.08%)	⬆️
mbt	14.66% <ø> (-5.97%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
core	∅ <ø> (∅)
engine	∅ <ø> (∅)
app	∅ <ø> (∅)
starknet	∅ <ø> (∅)

[romac]

@ancazamfir Note that I had to disable all tests pertaining to proposal-only and proposal-and-parts consensus modes since the Starknet protos do not include a Proposal message anymore (I mean they never did, we defined our own but I removed it for clarity). Eventually we will be able to run those again with the test app from #747.

[romac]

I also commented out vote extensions support for the Starknet app since those are not supported nor currently wanted by Starknet.

[ancazamfir]

App panics here if configured with proposal-and-parts.

[ancazamfir]

looks good! 🚀

[ancazamfir]

@ancazamfir Note that I had to disable all tests pertaining to proposal-only and proposal-and-parts consensus modes since the Starknet protos do not include a Proposal message anymore (I mean they never did, we defined our own but I removed it for clarity). Eventually we will be able to run those again with the test app from #747.

I think we should remove the value_payload from the consensus config and instead pass this down from the app. The app itself may hardcode this or, if we want to test multiple options from a test app, we make it part of the app config, controlled by tests.

[romac]

I think we should remove the value_payload from the consensus config and instead pass this down from the app. The app itself may hardcode this or, if we want to test multiple options from a test app, we make it part of the app config, controlled by tests.

Agreed! Let's do in a follow-up PR?

EDIT: Tracked here: #835