Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Modelator data directory after update #151

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Dec 7, 2021

Closes: #147

Description

Removes unexpected jars from Modelator data directory.

This usually happens when we update a model checker jar with a latest one.

This feature would be deprecated soon and use release assets from original releases.


For contributor use:

  • If applicable, unit tests are written and added to CI. Already taken care of.
  • Ran go fmt, cargo fmt and etc. (or had formatting run automatically on all files edited)
  • Updated relevant documentation (docs/) and code comments. Not needed.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Re-reviewed Files changed in the Github PR explorer.
  • Added a changelog entry, using unclog.

@rnbguy rnbguy changed the title remove unexpected jars Cleanup Modelator data directory after update Dec 7, 2021
@rnbguy rnbguy changed the title Cleanup Modelator data directory after update Clean Modelator data directory after update Dec 7, 2021
@rnbguy rnbguy requested a review from danwt December 7, 2021 17:29
@rnbguy rnbguy self-assigned this Dec 7, 2021
@rnbguy rnbguy added the bug Something isn't working label Dec 7, 2021
@rnbguy rnbguy added this to the 12.2021 milestone Dec 7, 2021
@rnbguy rnbguy merged commit 14bc09c into main Dec 7, 2021
@rnbguy rnbguy mentioned this pull request Dec 9, 2021
@danwt danwt deleted the rnbguy/rust/jar-directory-cleanup branch January 18, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Clear up or ignore unused .jar files when upgrading modelator.
1 participant