Reintroduces a simple Artifact trait which TlaFile implements. Begins cleanup of path assumptions. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 24, 2021 14:02
commit ee4c1dc Author: Daniel Tisdall <daniel@informal.systems> Date: Tue Aug 24 13:59:35 2021 +0100 Adds todos to Apalache and Tlc mod.rs's commit 97e6260 Author: Daniel Tisdall <daniel@informal.systems> Date: Tue Aug 24 13:48:17 2021 +0100 Removes todo in tla module generate_test commit e250158 Author: Daniel Tisdall <daniel@informal.systems> Date: Tue Aug 24 13:48:01 2021 +0100 Clarifies file path var names in cli commit 5fae1aa Author: Daniel Tisdall <daniel@informal.systems> Date: Tue Aug 24 13:30:45 2021 +0100 Partially refactors the use of TlaFile in tla module commit b3f74f1 Author: Daniel Tisdall <daniel@informal.systems> Date: Tue Aug 24 13:11:41 2021 +0100 TlaFile now saves content and filename internally commit e964abd Author: Daniel Tisdall <daniel@informal.systems> Date: Tue Aug 24 12:51:23 2021 +0100 Renames tla_module_name -> tla_file_name commit 84ab1b6 Author: Daniel Tisdall <daniel@informal.systems> Date: Tue Aug 24 12:32:44 2021 +0100 Pre TlaFile explicit pathing teardown commit 2438928 Author: Daniel Tisdall <daniel@informal.systems> Date: Tue Aug 24 12:19:56 2021 +0100 Scaffolds Artifact impl for tla_file commit 717de02 Author: Daniel Tisdall <daniel@informal.systems> Date: Tue Aug 24 12:16:08 2021 +0100 Reworks Artifact trait to use TryFrom super traits commit 7bf78ec Author: Daniel Tisdall <daniel@informal.systems> Date: Tue Aug 24 11:22:12 2021 +0100 Clarifies path/file var naming in lib.rs traces commit a3ef51f Author: Daniel Tisdall <daniel@informal.systems> Date: Tue Aug 24 11:16:44 2021 +0100 Clarifies naming of internal struct in tla_trace commit bbf6156 Author: Daniel Tisdall <daniel@informal.systems> Date: Tue Aug 24 11:16:28 2021 +0100 Adds artifact trait impl scaffold to .tla and .cfg reprs. commit 9fca5e3 Author: Daniel Tisdall <daniel@informal.systems> Date: Tue Aug 24 11:00:36 2021 +0100 Clarifies method names in mod.rs commit feeaa85 Author: Daniel Tisdall <daniel@informal.systems> Date: Tue Aug 24 10:48:58 2021 +0100 Adds basic artifact declarations commit 4554862 Author: Daniel Tisdall <daniel@informal.systems> Date: Tue Aug 24 10:18:39 2021 +0100 Adds artifacts trait commit 36be5a5 Author: Daniel Tisdall <daniel@informal.systems> Date: Tue Aug 24 10:18:32 2021 +0100 note commit 3f58ab0 Merge: be608de a905c1f Author: Daniel Tisdall <daniel@informal.systems> Date: Tue Aug 24 09:56:51 2021 +0100 Merge branch 'main' into daniel/working commit be608de Author: Daniel Tisdall <daniel@informal.systems> Date: Mon Aug 23 15:17:49 2021 +0100 settings.json commit 41ffa6e Merge: b6102a7 0db7f5e Author: Daniel Tisdall <daniel@informal.systems> Date: Mon Aug 23 14:34:50 2021 +0100 Merge branch 'main' into daniel/working commit b6102a7 Author: Daniel Tisdall <daniel@informal.systems> Date: Mon Aug 23 14:13:44 2021 +0100 Adds my own notes commit 660bdb5 Author: Daniel Tisdall <daniel@informal.systems> Date: Mon Aug 23 14:05:07 2021 +0100 Adds apalache debug launcher commit 3afa62e Author: Daniel Tisdall <daniel@informal.systems> Date: Mon Aug 23 14:04:48 2021 +0100 Adds trace.tla and log.mc to .gitignore commit b88b76c Author: Daniel Tisdall <daniel@informal.systems> Date: Mon Aug 23 12:06:20 2021 +0100 Gignores Dans vscode commit e423305 Author: Daniel Tisdall <daniel@informal.systems> Date: Mon Aug 23 12:05:23 2021 +0100 notes commit 0b2a83e Author: Daniel Tisdall <daniel@informal.systems> Date: Mon Aug 23 11:08:07 2021 +0100 Adds some notes-to-self
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the Artifact trait which will wrap things such as TlaFile, TlaConfigFile, JsonTrace ect... This will eventually help to remove all path assuming code. Have taken the simple and gradual approach, enhancements can come later.
Currently partially implemented the trait for TlaFile and did related cleanups.
Note: please squash.