Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement validation/execution contexts #1

Merged
merged 12 commits into from
Sep 7, 2023
Merged

Implement validation/execution contexts #1

merged 12 commits into from
Sep 7, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Sep 1, 2023 •
edited
Loading

Remarks:

  • Related to the implementation of commitment_prefix method: as the entire module prefix consists of the module's name derived from its struct name (and for consistency with other module names as well) the IbcModule struct renamed to Ibc.

  • Methods like host_height need info from the host, left unimplemented to work on in a separate PR.

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review September 5, 2023 14:17
plafer
plafer approved these changes Sep 7, 2023
View reviewed changes
Copy link

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@plafer plafer merged commit 6d873aa into plafer/ibc-integration Sep 7, 2023
1 check passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/ibc-impl-contexts branch September 22, 2023 17:10
@Farhad-Shabani Farhad-Shabani mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plafer plafer plafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Farhad-Shabani @plafer