Replace RPC ABCI types with ABCI domain types (#1204)

* Remove local ABCI module import

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Refactor abci_info endpoint to use domain type

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Replace RPC ABCI Path with a String

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Replace all uses of tendermint_rpc::abci::transaction::Hash with tendermint::Hash

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* rpc: Remove abci::Responses

Does not seem to be used for anything.

* rpc: Replace DeliverTx and Event with domain types

First attempt, with a serialization snag in tendermint-proto.

* Serialize some ABCI domain types directly

Instead of deriving serde on raw proto types to de/serialize
abci::response::DeliverTx, abci::Event, and abci::EventAttribute,
derive on the domain types directly.
This disentangles the serialization, now primarily used by JSON-RPC,
from protobuf struct definitions which are subject to change for
Tendermint Core 0.37 (in case of EventAttribute).

* Serialize gas as strings in response::DeliverTx

* rpc: Eliminate abci::Gas

In tendermint-rpc, the only place where Gas newtype is still used
is in the response to /broadcast_tx_commit, which is a development-only
endpoint. Leave the response struct defined through tx_commit::TxResult
for the time being.
Define serialization of abci::response::CheckTx (currently not used)
to match that of DeliverTx.

* Nullable serializer for data fields of ABCI responses

* rpc: Remove abci::Data

* rpc: Remove abci::Log

* rpc: Remove abci::Info

* rpc: Replace BeginBlock/EndBlock with domain types

Also in tendermint, remove validator::Update which duplicates
abci::types::ValidatorUpdate.

* rpc: remove abci::Codespace

With it goes mod abci::responses.

* Post-merge fixup

* Fix integration tests

* Fix clippy lints

* Convert abci::ValidatorUpdate to validator::Update

* rpc: Move abci::Code to crate tendermint

Promote this to a proper domain type.

* Replace u32 code fields with Code

* rpc: Eliminate abci::Transaction

This was the last of the ABCI helper types defined in tendermint-rpc,
and with it goes the abci module.

* Fix tools build

* Changelog entry for #1204

* Use domain types in /broadcast_tx_commit response

* Fix serialization of priority field in CheckTx response

* Default the field values of CheckTx/DeliverTx

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Thane Thomson <connect@thanethomson.com>

.changelog/unreleased/breaking-changes/1204-rpc-abci-domain-types.md

@@ -0,0 +1,3 @@
+- `[tendermint-rpc]` Remove ABCI-related types, change the affected field types
+  to standard Rust types or ABCI domain types in `[tendermint]`.
+  ([#1090](https://github.com/informalsystems/tendermint-rs/issues/1090))

light-client/src/evidence.rs

@@ -2,7 +2,7 @@
 
 use contracts::contract_trait;
 pub use tendermint::evidence::Evidence;
-use tendermint_rpc::abci::transaction::Hash;
+use tendermint::Hash;
 
 use crate::{components::io::IoError, verifier::types::PeerId};
 

light-client/src/tests.rs

@@ -7,9 +7,10 @@ use serde::{Deserialize, Serialize};
 use tendermint::{
     block::Height as HeightStr,
     evidence::{Duration as DurationStr, Evidence},
+    hash::Algorithm,
+    Hash,
 };
 use tendermint_rpc as rpc;
-use tendermint_rpc::abci::transaction::Hash;
 
 use crate::{
     components::{
@@ -133,7 +134,7 @@ pub struct MockEvidenceReporter;
 #[contract_trait]
 impl EvidenceReporter for MockEvidenceReporter {
     fn report(&self, _e: Evidence, _peer: PeerId) -> Result<Hash, IoError> {
-        Ok(Hash::new([0; 32]))
+        Ok(Hash::from_bytes(Algorithm::Sha256, &[0; 32]).unwrap())
     }
 }
 

proto/src/serializers/bytes.rs

@@ -38,12 +38,14 @@ pub mod base64string {
     use crate::prelude::*;
 
     /// Deserialize base64string into `Vec<u8>`
-    pub fn deserialize<'de, D>(deserializer: D) -> Result<Vec<u8>, D::Error>
+    pub fn deserialize<'de, D, T>(deserializer: D) -> Result<T, D::Error>
     where
         D: Deserializer<'de>,
+        Vec<u8>: Into<T>,
     {
         let string = Option::<String>::deserialize(deserializer)?.unwrap_or_default();
-        base64::decode(&string).map_err(serde::de::Error::custom)
+        let v = base64::decode(&string).map_err(serde::de::Error::custom)?;
+        Ok(v.into())
     }
 
     /// Deserialize base64string into String