Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warnings with ed25519 1.3.0 #1023

Closed
mzabaluev opened this issue Nov 21, 2021 · 0 comments · Fixed by #1024
Closed

Deprecation warnings with ed25519 1.3.0 #1023

mzabaluev opened this issue Nov 21, 2021 · 0 comments · Fixed by #1024
Labels
bug Something isn't working

Comments

@mzabaluev
Copy link
Contributor

tendermint uses API from ed25519 that has become deprecated as of version 1.3.0.

Steps to reproduce

  1. Change the directory to a fresh working copy of tendermint-rs.
  2. Run cargo update.
  3. Try to build.

What's the definition of "done" for this issue?

No deprecation warnings are observed.
The tendermint API should probably deprecate its standalone ED25519_SIGNATURE_LENGTH const, as the associated const on the signature struct type is now the bees' knees.
@mzabaluev mzabaluev added the bug Something isn't working label Nov 21, 2021
@mzabaluev mzabaluev mentioned this issue Nov 22, 2021
Merged
5 tasks
@mzabaluev mzabaluev mentioned this issue Nov 26, 2021
Merged
mzabaluev added a commit that referenced this issue Nov 26, 2021
@mzabaluev
Fix up deprecation for ED25519_SIGNATURE_SIZE
6d38fee 
0.23.1 was released before #1023 or its backport to v0.23.x were merged.
mzabaluev added a commit that referenced this issue Nov 26, 2021
@mzabaluev
Fix up deprecation for ED25519_SIGNATURE_SIZE
82a0eac 
0.23.1 was released before #1023 or its backport to v0.23.x were merged.
@mzabaluev mzabaluev mentioned this issue Nov 26, 2021
Merged
thanethomson pushed a commit that referenced this issue Nov 26, 2021
@mzabaluev
Update to deprecations in ed25519 1.3 (backport to 0.23.x) (#1031)
1dedd72 
* Update to deprecations in ed25519 1.3 (#1024)

* Fix up deprecation for ED25519_SIGNATURE_SIZE

0.23.1 was released before #1023 or its backport to v0.23.x were merged.
thanethomson pushed a commit that referenced this issue Nov 26, 2021
@mzabaluev
Fix up deprecation for ED25519_SIGNATURE_SIZE (#1032)
9cd12b0 
0.23.1 was released before #1023 or its backport to v0.23.x were merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to deprecations in ed25519 1.3 informalsystems/tendermint-rs
1 participant
@mzabaluev