Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Tokio to version 0.3.0 #683

Closed
romac opened this issue Nov 18, 2020 · 0 comments · Fixed by #681
Closed

Upgrade Tokio to version 0.3.0 #683

romac opened this issue Nov 18, 2020 · 0 comments · Fixed by #681
Labels
Milestone

Comments

@romac
Copy link
Member

romac commented Nov 18, 2020

Implemented in: #681

Crates

rpc, light-client, light-node

Summary

Upgrade Tokio to version 0.3 to benefit from it's improved Runtime to facilitate integration of async tasks within sync code.

Problem Definition

The upcoming chain runtime in ibc-rs needs to bridge the gap between async and sync code.

The improved Runtime in Tokio 0.3 would help us implement a better chain runtime, thanks to its ability to be wrapped in an Arc, and shared between threads and components while still allowing to block_on futures.

This would also be useful for the light client: with Tokio 0.3, we can avoid spawning a new thread+runtime when blocking on each RPC request and instead have the Io component be parametrized with a Tokio Runtime.

Proposal

  • Upgrade Tokio to version 0.3.
  • Upgrade all dependencies which depends on Tokio 0.2 to newer versions for Tokio 0.3 support.
    • async-tungstenite: 0.8 => 0.10
    • hyper: 0.13 => 0.14.0-dev (development version)
@romac romac added the breaking label Nov 18, 2020
@romac romac added this to the v0.17.0 milestone Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant