Upgrade Tokio to version 0.3.0

[romac]

Close: #683

Target: v0.17.0-rc4

• Upgrade Tokio to version 0.3.
• Upgrade all dependencies which depends on Tokio 0.2 to newer versions for Tokio 0.3 support.
  • async-tungstenite: 0.8 => 0.10
  • hyper: 0.13 => 0.14.0-dev (development version)

---

• Referenced an issue explaining the need for the change
• Updated all relevant documentation in docs
• Updated all code comments where relevant
• Wrote tests
• Updated CHANGELOG.md

[tony-iqlusion]

It'd be really helpful if we could get another -rc release with #679 fixed before this lands.

It's a breaking change to TMKMS to upgrade Tokio and we haven't done it yet, and we need to be able to test Stargate upgrades with production keys ASAP.

[thanethomson]

It'd be really helpful if we could get another -rc release with #679 fixed before this lands.

It's a breaking change to TMKMS to upgrade Tokio and we haven't done it yet, and we need to be able to test Stargate upgrades with production keys ASAP.

Sure - I'd say we should target v0.17.0-rc4 to upgrade Tokio 👍 (rc3 will release the fix for #679)

[codecov-io]

Codecov Report

Merging #681 (53ae372) into master (91bc1f6) will increase coverage by 0.0%.
The diff coverage is 29.4%.

@@          Coverage Diff           @@
##           master    #681   +/-   ##
======================================
  Coverage    39.4%   39.5%           
======================================
  Files         191     191           
  Lines       12595   12592    -3     
  Branches     3234    3229    -5     
======================================
+ Hits         4974    4981    +7     
+ Misses       7284    7274   -10     
  Partials      337     337           

Impacted Files	Coverage Δ
light-client/src/components/io.rs	0.0% <ø> (ø)
light-client/src/utils/block_on.rs	0.0% <0.0%> (ø)
light-node/src/application.rs	0.0% <0.0%> (ø)
light-node/src/commands/start.rs	0.0% <0.0%> (ø)
tendermint/tests/integration.rs	0.4% <0.0%> (ø)
rpc/src/client/subscription.rs	74.0% <100.0%> (+1.4%)	⬆️
rpc/src/client/sync.rs	57.1% <100.0%> (+7.1%)	⬆️
rpc/src/client/transport/websocket.rs	73.0% <100.0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91bc1f6...53ae372. Read the comment docs.

[melekes]

👍

[thanethomson]

Thanks for this! 👍 I was wondering when this was going to become necessary 😁

[romac]

FWIW, I initially did it the unsafe and manual way, but that unsafe block kept me most of the following night, so I figured I'd rather trust a real Rust dev and take the (admittedly very small) compile-time + code size penalty with pin-project.

[romac]

Before/after: 7c8f444

[thanethomson]

Looks awesome! 👍

[adizere]

As a temporary workaround, the PR informalsystems/hermes#364 depends on branch romac/upgrade-tokio here. We'll delete this branch later once it's not needed anymore.