-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc: Add temporary fix and tests for block_results
serialization
#1061
Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
…vstore Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
…eInfo over ABCI and RPC Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
This introduces a (somewhat hacky, yet temporary) approach to being able to deserialize public keys in validator updates until such time that Tendermint addresses the problem. Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Codecov Report
@@ Coverage Diff @@
## v0.23.x #1061 +/- ##
=========================================
- Coverage 66.1% 65.1% -1.0%
=========================================
Files 209 210 +1
Lines 21023 20744 -279
=========================================
- Hits 13913 13522 -391
- Misses 7110 7222 +112
Continue to review full report at Codecov.
|
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work Thane!
Confirm this works with the provided tests.
One last thought: Would it be worthwhile to make a PR on Hermes pinned with a dependency on this branch, and then pass it to Injective folks for further end-to-end testing? It seems unlikely we can uncover anything with this additional step, but not sure.
* Rename kvstore module to common, since it provides common RPC requests Signed-off-by: Thane Thomson <connect@thanethomson.com> * Rename quick module to kvstore, since it caters exclusively for the kvstore Signed-off-by: Thane Thomson <connect@thanethomson.com> * Move attribute after comment Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add support for simple query plan for Gaia Signed-off-by: Thane Thomson <connect@thanethomson.com> * Enable rustls for wss support Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix clippy lint Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add changelog entry Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Add convenience method to decode RPC requests from strings Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add deserialization workaround for validator updates This introduces a (somewhat hacky, yet temporary) approach to being able to deserialize public keys in validator updates until such time that Tendermint addresses the problem. Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add changelog entry Signed-off-by: Thane Thomson <connect@thanethomson.com>
Closes #1021
The important changes are in:
tendermint/src/public_key.rs
tendermint/src/validator.rs
The reason for the massive line count in this PR:
rpc/tests/support
folder and its fixtures, since those were manually generated, in favour of automatically generated fixtures from the rpc-probe (this PR also introduces a small query plan for interacting with a Gaia node).curl http://18.191.147.51:26657/block_results?height=4555980
is added in here as a specific test case to ensure it parses.One simple way of verifying this code is to check out this branch locally and then, from the root of the repository, run:
.changelog/