Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Switch hyper-proxy to use rustls #1068

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

mzabaluev
Copy link
Contributor

@mzabaluev mzabaluev commented Dec 22, 2021

Fixes: informalsystems/hermes#1641

The rest of the stack already uses rustls for their TLS needs.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

The rest of the stack already uses rustls for their TLS needs.
@mzabaluev mzabaluev added dependencies Pull requests that update a dependency file rpc labels Dec 22, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1068 (1702069) into master (a121189) will increase coverage by 0.3%.
The diff coverage is n/a.

❗ Current head 1702069 differs from pull request most recent head 40d5302. Consider uploading reports for the commit 40d5302 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1068     +/-   ##
========================================
+ Coverage    62.7%   63.1%   +0.3%     
========================================
  Files         236     236             
  Lines       21192   21058    -134     
========================================
- Hits        13296   13292      -4     
+ Misses       7896    7766    -130     
Impacted Files Coverage Δ
abci/src/codec.rs 87.8% <0.0%> (-1.4%) ⬇️
testgen/src/vote.rs 84.0% <0.0%> (-0.9%) ⬇️
abci/src/server.rs 8.8% <0.0%> (-0.4%) ⬇️
tendermint/src/node.rs 63.5% <0.0%> (-0.2%) ⬇️
testgen/src/header.rs 79.3% <0.0%> (+0.6%) ⬆️
tendermint/src/hash.rs 65.1% <0.0%> (+33.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a121189...40d5302. Read the comment docs.

thanethomson pushed a commit that referenced this pull request Jan 10, 2022
* rpc: Switch hyper-proxy to use rustls

The rest of the stack already uses rustls for their TLS needs.

* Changelog entry for #1068
@thanethomson thanethomson merged commit 8d77986 into master Jan 10, 2022
@thanethomson thanethomson deleted the mikhail/switch-hyper-proxy-to-rustls branch January 10, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rpc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harmonize the dependencies to use a single TLS stack
3 participants