Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace RPC ABCI types with ABCI domain types #1204

Merged
merged 29 commits into from
Nov 5, 2022
Merged

Replace RPC ABCI types with ABCI domain types #1204

merged 29 commits into from
Nov 5, 2022

Commits on Sep 28, 2022

  1. Remove local ABCI module import 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson @mzabaluev
    thanethomson authored and mzabaluev committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    f7502a7 View commit details
    Browse the repository at this point in the history

  2. Refactor abci_info endpoint to use domain type 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson @mzabaluev
    thanethomson authored and mzabaluev committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    77af375 View commit details
    Browse the repository at this point in the history

  3. Replace RPC ABCI Path with a String 

    Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson @mzabaluev
    thanethomson authored and mzabaluev committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    6d41cfd View commit details
    Browse the repository at this point in the history

  4. Replace all uses of tendermint_rpc::abci::transaction::Hash with tend… 

    …ermint::Hash

Signed-off-by: Thane Thomson <connect@thanethomson.com>
    @thanethomson @mzabaluev
    thanethomson authored and mzabaluev committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    95aee68 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2022

  1. rpc: Remove abci::Responses 

    Does not seem to be used for anything.
    @mzabaluev
    mzabaluev committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    6b5798c View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. rpc: Replace DeliverTx and Event with domain types 

    First attempt, with a serialization snag in tendermint-proto.
    @mzabaluev
    mzabaluev committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    5a7953f View commit details
    Browse the repository at this point in the history

  2. Serialize some ABCI domain types directly 

    Instead of deriving serde on raw proto types to de/serialize
abci::response::DeliverTx, abci::Event, and abci::EventAttribute,
derive on the domain types directly.
This disentangles the serialization, now primarily used by JSON-RPC,
from protobuf struct definitions which are subject to change for
Tendermint Core 0.37 (in case of EventAttribute).
    @mzabaluev
    mzabaluev committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    58fecb5 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Serialize gas as strings in response::DeliverTx

    @mzabaluev
    mzabaluev committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    879f1fc View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. rpc: Eliminate abci::Gas 

    In tendermint-rpc, the only place where Gas newtype is still used
is in the response to /broadcast_tx_commit, which is a development-only
endpoint. Leave the response struct defined through tx_commit::TxResult
for the time being.
Define serialization of abci::response::CheckTx (currently not used)
to match that of DeliverTx.
    @mzabaluev
    mzabaluev committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    0b0382f View commit details
    Browse the repository at this point in the history

  2. Nullable serializer for data fields of ABCI responses

    @mzabaluev
    mzabaluev committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    7235354 View commit details
    Browse the repository at this point in the history

  3. rpc: Remove abci::Data

    @mzabaluev
    mzabaluev committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    8849441 View commit details
    Browse the repository at this point in the history

  4. rpc: Remove abci::Log

    @mzabaluev
    mzabaluev committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    a565367 View commit details
    Browse the repository at this point in the history

  5. rpc: Remove abci::Info

    @mzabaluev
    mzabaluev committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    e0673a3 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. rpc: Replace BeginBlock/EndBlock with domain types 

    Also in tendermint, remove validator::Update which duplicates
abci::types::ValidatorUpdate.
    @mzabaluev
    mzabaluev committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    f6c670e View commit details
    Browse the repository at this point in the history

  2. rpc: remove abci::Codespace 

    With it goes mod abci::responses.
    @mzabaluev
    mzabaluev committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    5725d4f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into thane+mikhail/rpc-abci-domain-types

    @mzabaluev
    mzabaluev committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    897e595 View commit details
    Browse the repository at this point in the history

  4. Post-merge fixup

    @mzabaluev
    mzabaluev committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    35d39e9 View commit details
    Browse the repository at this point in the history

  5. Fix integration tests

    @mzabaluev
    mzabaluev committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    be27082 View commit details
    Browse the repository at this point in the history

  6. Fix clippy lints

    @mzabaluev
    mzabaluev committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    da53dc3 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Convert abci::ValidatorUpdate to validator::Update

    @mzabaluev
    mzabaluev committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    f4d4bf0 View commit details
    Browse the repository at this point in the history

  2. rpc: Move abci::Code to crate tendermint 

    Promote this to a proper domain type.
    @mzabaluev
    mzabaluev committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    c03dc06 View commit details
    Browse the repository at this point in the history

  3. Replace u32 code fields with Code

    @mzabaluev
    mzabaluev committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    71a774c View commit details
    Browse the repository at this point in the history

  4. rpc: Eliminate abci::Transaction 

    This was the last of the ABCI helper types defined in tendermint-rpc,
and with it goes the abci module.
    @mzabaluev
    mzabaluev committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    c7652b4 View commit details
    Browse the repository at this point in the history

  5. Fix tools build

    @mzabaluev
    mzabaluev committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    9998ec1 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Changelog entry for #1204

    @mzabaluev
    mzabaluev committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    b445957 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Use domain types in /broadcast_tx_commit response

    @mzabaluev
    mzabaluev committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    03a8bf6 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Fix serialization of priority field in CheckTx response

    @mzabaluev
    mzabaluev committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    d566fe7 View commit details
    Browse the repository at this point in the history

  2. Default the field values of CheckTx/DeliverTx

    @mzabaluev
    mzabaluev committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    dc1f3fb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into thane+mikhail/rpc-abci-domain-types

    @mzabaluev
    mzabaluev committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    3d211df View commit details
    Browse the repository at this point in the history