Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light-node: cli #430

Merged
merged 34 commits into from
Jul 13, 2020
Merged

light-node: cli #430

merged 34 commits into from
Jul 13, 2020

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Jul 9, 2020

Light node commands as described in #293 (comment)

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

@liamsi liamsi requested review from xla, romac and milosevic July 9, 2020 14:57
@liamsi liamsi mentioned this pull request Jul 9, 2020
5 tasks
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra dope! So much work, really good to see it come together.

light-node/Cargo.toml Show resolved Hide resolved
light-node/README.md Outdated Show resolved Hide resolved
light-node/light_node.toml.example Outdated Show resolved Hide resolved
light-node/src/commands/initialize.rs Show resolved Hide resolved
light-node/src/commands/initialize.rs Show resolved Hide resolved
light-node/src/commands/start.rs Show resolved Hide resolved
light-node/src/commands/start.rs Outdated Show resolved Hide resolved
light-node/src/commands/start.rs Show resolved Hide resolved
light-node/src/commands/start.rs Show resolved Hide resolved
light-node/src/config.rs Show resolved Hide resolved
@xla xla changed the title Light-Node CLI light-node: cli Jul 10, 2020
@xla xla added feature light-client Issues/features which involve the light client labels Jul 10, 2020
xla
xla previously requested changes Jul 11, 2020
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dope dope dope! Massive chunk. We should make sure that for all conversations that are left for the future we have follow-up issues.

Also I find it strange that we have a dedicated light-node bin in the light-node crate, can't we just use the main main?

light-node/light_node.toml.example Outdated Show resolved Hide resolved
light-node/src/commands/initialize.rs Show resolved Hide resolved
light-node/src/commands/start.rs Outdated Show resolved Hide resolved
light-node/src/commands/start.rs Outdated Show resolved Hide resolved
light-node/src/commands/start.rs Outdated Show resolved Hide resolved
light-node/src/config.rs Show resolved Hide resolved
light-node/src/config.rs Show resolved Hide resolved
light-node/src/commands/start.rs Outdated Show resolved Hide resolved
light-node/src/commands/start.rs Show resolved Hide resolved
light-node/src/commands/start.rs Outdated Show resolved Hide resolved
@liamsi
Copy link
Member Author

liamsi commented Jul 11, 2020

We should make sure that for all conversations that are left for the future we have follow-up issues.

I was planning to go through each comment and capture everything (that's not yet addressed) in a followup issue after this gets merged. Ok?

Also I find it strange that we have a dedicated light-node bin in the light-node crate, can't we just use the main main?

That's the way absicca generates the create structure on init. e.g. running abscissa new test-app yields:

tree                                                                                                                                                                                
.
`-- test-app
    |-- Cargo.lock
    |-- Cargo.toml
    |-- README.md
    |-- src
    |   |-- application.rs
    |   |-- bin
    |   |   `-- test_app
    |   |       `-- main.rs
    |   |-- commands
    |   |   |-- start.rs
    |   |   `-- version.rs
    |   |-- commands.rs
    |   |-- config.rs
    |   |-- error.rs
    |   |-- lib.rs
    |   `-- prelude.rs
    `-- tests
        `-- acceptance.rs

@tarcieri can you provide some input on the rationale here?

@liamsi liamsi added the documentation Improvements or additions to documentation label Jul 12, 2020
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @liamsi! Only have a few comments/questions inline, but looks great otherwise :)

light-node/src/commands/initialize.rs Show resolved Hide resolved
light-node/src/commands/initialize.rs Show resolved Hide resolved
light-node/src/commands/initialize.rs Show resolved Hide resolved
light-node/src/commands/initialize.rs Show resolved Hide resolved
light-node/src/commands/start.rs Show resolved Hide resolved
@liamsi liamsi mentioned this pull request Jul 13, 2020
@liamsi
Copy link
Member Author

liamsi commented Jul 13, 2020

Captured all feedback and open issues in #442

Copy link
Contributor

@brapse brapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. Feel good about this and the follow ups 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature light-client Issues/features which involve the light client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants