-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
light-node: cli #430
light-node: cli #430
Conversation
- increase request timeout
d2e12fb
to
996c550
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra dope! So much work, really good to see it come together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dope dope dope! Massive chunk. We should make sure that for all conversations that are left for the future we have follow-up issues.
Also I find it strange that we have a dedicated light-node
bin in the light-node
crate, can't we just use the main main?
I was planning to go through each comment and capture everything (that's not yet addressed) in a followup issue after this gets merged. Ok?
That's the way absicca generates the create structure on init. e.g. running
@tarcieri can you provide some input on the rationale here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @liamsi! Only have a few comments/questions inline, but looks great otherwise :)
Captured all feedback and open issues in #442 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. Feel good about this and the follow ups 👍
Light node commands as described in #293 (comment)