Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merkle: return rfc6962 hash for empty merkle tree #514

Merged
merged 3 commits into from
Aug 11, 2020

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Aug 11, 2020

fixes #498
related golang changes: tendermint/tendermint#5193

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@liamsi liamsi added breaking go Compatibility with Go code bug Something isn't working labels Aug 11, 2020
@liamsi liamsi marked this pull request as ready for review August 11, 2020 12:58
@codecov-commenter
Copy link

Codecov Report

Merging #514 into master will increase coverage by 0.1%.
The diff coverage is 56.2%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #514     +/-   ##
========================================
+ Coverage    29.5%   29.7%   +0.1%     
========================================
  Files         135     135             
  Lines        5468    5481     +13     
  Branches     1700    1698      -2     
========================================
+ Hits         1617    1630     +13     
  Misses       2792    2792             
  Partials     1059    1059             
Impacted Files Coverage Δ
tendermint/src/merkle.rs 57.6% <56.2%> (+2.0%) ⬆️
light-client/src/tests.rs 49.5% <0.0%> (+0.8%) ⬆️
light-client/src/peer_list.rs 50.9% <0.0%> (+1.2%) ⬆️
light-client/src/state.rs 45.0% <0.0%> (+5.0%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da9e177...b319e42. Read the comment docs.

Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📷 🐲 👐 🍺

@liamsi liamsi merged commit 9295676 into master Aug 11, 2020
@liamsi liamsi deleted the ismail/fix_simple-merkle_empty-case branch August 11, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking bug Something isn't working go Compatibility with Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

merkle tree: investigate divergance between go/rust implementation
4 participants