Testgen tester -- utilities to run multiple tests with logs and reports #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey-kuprianov
requested review from
xla,
romac,
thanethomson,
liamsi,
greg-szabo,
shonfeder and
Shivani912
andrey-kuprianov
changed the title
This was referenced Sep 4, 2020
romac
requested changes
Sep 9, 2020
|
@romac I think I've addressed all of your comments; thanks a lot for them; helped to improve the code substantially:) could you please take a look? |
|
Yeah the tests are currently failing on Let's merge this! |
romac
approved these changes
Sep 10, 2020
romac
pushed a commit
that referenced
this pull request
Sep 11, 2020
* #414: testgen tester -- utilities to run multiple tests with logs and reports * 14: add testgen commands, in particular to call apalache and jsonatr * #547 add missing file updates from #529 * fix merge typo * remove ref to time: it's in another PR * fix clippy warning * TestEnv: change path parameters into AsRef<Path> * change TestEnv::full_path to return PathBuf * apply simplifications suggested by Romain * apply simplification from Romain * account for WOW Romain's suggestion on RefUnwindSafe * address Romain's suggestion on TestEnv::cleanup * cargo clippy * update CHANGELOG.md * addressed Romains's suggestions
romac
pushed a commit
that referenced
this pull request
Sep 11, 2020
* #414: testgen tester -- utilities to run multiple tests with logs and reports * 14: add testgen commands, in particular to call apalache and jsonatr * #414: add model-based test driver to LightClient tests * add talk abstract * #547 add missing file updates from #529 * fix merge typo * remove ref to time: it's in another PR * fix clippy warning * fix merging typo * cargo fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 or #529. See also #414.
This PR introduces Testgen Tester. The preliminary version of it appeared in #525, but as that PR has not received sufficient number of reviews, please consider the whole code of
tester.rsas new.